Skip to content

refactor: extract ManuallyReportedException to :common#20956

Merged
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:refactor/ManuallyReportedException
May 5, 2026
Merged

refactor: extract ManuallyReportedException to :common#20956
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:refactor/ManuallyReportedException

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

Extract ManuallyReportedException to common, one step closer to our clean goal

Fixes

Approach

See commit

How Has This Been Tested?

Local build

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

The class is a pure RuntimeException subclass with no Android dependencies,
so it lives in :common rather than :common:android. Removes one more
dependency on :AnkiDroid for feature module extraction.
@david-allison david-allison enabled auto-merge May 5, 2026 19:12
@david-allison david-allison added this pull request to the merge queue May 5, 2026
Merged via the queue into ankidroid:main with commit 9d3a70f May 5, 2026
20 of 21 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants